Fix for slurs and slur layout improvement #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quarter note causes crash, improve slur default layout on stem-stem case
|
I've tested this using many files that have whole note and slur and crashes before, and they can work well now. |
|
i manually applied the changes (ws). |
Xmader
added a commit
to Xmader/MuseScore
that referenced
this pull request
Nov 6, 2020
Xmader
added a commit
to Xmader/MuseScore
that referenced
this pull request
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #17544: Inverting slur between whole note (no stem) and quarter note causes crash, improve slur default layout on stem-stem case.
The layout of Stem-Stem slurs has been changed. There are closer to the stems because it seems better and other scorewriters do it this way. Maybe Gould should be checked?
The code should also now handle whole to quarter and quarter to whole slurs correctly.
PDF made with this fix, nothing tweaked : https://dl.dropbox.com/u/497455/slurtest.pdf
The mscz file (will probably not open before the fix, because of #17544): https://dl.dropbox.com/u/497455/slurtest.mscz