fix #116881: dynamic translation #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasconic
force-pushed
the
fix-116881-dynamic-translation
branch
from
4bccb12
to
573ebab
Compare
| @@ -185,6 +186,8 @@ void ResourceManager::download() | |||
| if (result) { | |||
| QFile::remove(localPath); | |||
| button->setText(tr("Updated")); | |||
| // retranslate the UI | |||
| setMscoreLocale(localeName); | |||
There was a problem hiding this comment.
When guarded by if (data == buttonMap.first()) this would only be done when really needed, i.e. if the current active language got updated
lasconic
force-pushed
the
fix-116881-dynamic-translation
branch
from
573ebab
to
9471a7c
Compare
lasconic
force-pushed
the
fix-116881-dynamic-translation
branch
from
9471a7c
to
46c9157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.