-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToolButtonMenu for switching between Note Entry Modes #2719
Conversation
Please don't merge unless this is fully rebased and fully up-to-date with the master branch! |
d0c57fd
to
c725d7b
Compare
@@ -27,7 +27,6 @@ | |||
<file>data/icons/png/window-close-hover@2x.png</file> | |||
<file>data/icons/png/window-float.png</file> | |||
<file>data/icons/png/window-float@2x.png</file> | |||
<file>revision.h</file> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is needed by musescore.cpp, line 5184 (before this commit), a few lines into main()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good catch! I was testing something but forgot to put it back afterwards.
c725d7b
to
4ec092e
Compare
4ec092e
to
053307d
Compare
I merged this. Be aware that it breaks repitch mode. So looking forward to your next PR to fix that and implement other modes. |
It looks like repitch mode was actually broken a few weeks ago by 1a8cdf1. It might be a good idea to have a test for repitch mode. I'll make one when I get around to making tests for the other modes. |
I pulled MuseScore-master from GitHub. I have MuseScore2 version 2.1.0 installed. Do I need to install MuseScore-master to get the new dropdown? |
No, the dropdown is already in MuseScore 2.1 |
Do you know what I need to do to get the new Note Input options to show? The 3 new Note Input options do not show preferences. |
If you have 2.1 they are there. Be sure you really have 2.1 - see Help /
About. And then look closely just to the right of the "N" icon on the note
input toolbar - that's where the drop down is. It's not in Preferences.
…On Thu, Sep 21, 2017 at 8:10 AM mscscf ***@***.***> wrote:
Do you know what I need to do to get the new Note Input options to show?
The 3 new Note Input options do not show preferences.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2719 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABt3AKoEl4eSx-CTdEl11rgoHPOyUWXdks5skmz3gaJpZM4JD-T3>
.
|
Ok thanks for your help. I see them now. I'll give them a try. Somehow I got the idea the options were in preferences. Not just on the main screen. |
How can I pick up the nightly builds instead of waiting for version 3.0? In case there are fixes in the nightly builds. |
Nightly builds for 2.x are available on the Downloads page of the main
site. Don't use "master" builds, they are extremely unstable and
unsupported.
Also for future reference, it is best to ask for help on the Support forum.
…On Thu, Sep 21, 2017 at 10:00 AM mscscf ***@***.***> wrote:
How can I pick up the nightly builds instead of waiting for version 3.0?
In case there are fixes in the nightly builds.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2719 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABt3AEjxvME759EsGks7wQtQvDC0SUYmks5skogrgaJpZM4JD-T3>
.
|
Ok thanks. If I need more info on getting the nightly builds, I'll look in
the forum. I saw comments that the rhythm option was broken on this page.
Hopefully that is fixed.
On Thu, Sep 21, 2017 at 10:12 AM, Marc Sabatella <notifications@github.com>
wrote:
… Nightly builds for 2.x are available on the Downloads page of the main
site. Don't use "master" builds, they are extremely unstable and
unsupported.
Also for future reference, it is best to ask for help on the Support forum.
On Thu, Sep 21, 2017 at 10:00 AM mscscf ***@***.***> wrote:
> How can I pick up the nightly builds instead of waiting for version 3.0?
> In case there are fixes in the nightly builds.
>
> —
> You are receiving this because you commented.
>
>
> Reply to this email directly, view it on GitHub
> <#2719 (comment)
>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
ABt3AEjxvME759EsGks7wQtQvDC0SUYmks5skogrgaJpZM4JD-T3>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2719 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AeqU1eyCuqAm7svtbNy1AJ7om_YQtmSsks5skosBgaJpZM4JD-T3>
.
|
Adds a dropdown menu for choosing note entry mode.
The ToolButtonMenu class is useful for grouping related actions under a single toolbar icon. It could be used to consolidate other actions in the future. For example:
A ToolButtonMenu for augmentation dots would allow the user to choose how many dots to add, with the default being one.