Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolButtonMenu for switching between Note Entry Modes #2719

Merged
merged 5 commits into from
Jul 8, 2016

Conversation

shoogle
Copy link
Contributor

@shoogle shoogle commented Jul 3, 2016

Adds a dropdown menu for choosing note entry mode.

image

The ToolButtonMenu class is useful for grouping related actions under a single toolbar icon. It could be used to consolidate other actions in the future. For example:

  • Augmentation dots
  • Durations
  • Voices

A ToolButtonMenu for augmentation dots would allow the user to choose how many dots to add, with the default being one.

@shoogle
Copy link
Contributor Author

shoogle commented Jul 4, 2016

Please don't merge unless this is fully rebased and fully up-to-date with the master branch!
This is to ensure that the PR's commit hash is preserved in the master branch for authenticity purposes.

@shoogle shoogle force-pushed the semi-realtime-midi branch 2 times, most recently from d0c57fd to c725d7b Compare July 4, 2016 08:17
@@ -27,7 +27,6 @@
<file>data/icons/png/window-close-hover@2x.png</file>
<file>data/icons/png/window-float.png</file>
<file>data/icons/png/window-float@2x.png</file>
<file>revision.h</file>
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz Jul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is needed by musescore.cpp, line 5184 (before this commit), a few lines into main()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch! I was testing something but forgot to put it back afterwards.

@lasconic lasconic merged commit cb07375 into musescore:master Jul 8, 2016
@lasconic
Copy link
Contributor

lasconic commented Jul 8, 2016

I merged this. Be aware that it breaks repitch mode. So looking forward to your next PR to fix that and implement other modes.

@shoogle shoogle deleted the semi-realtime-midi branch July 8, 2016 16:35
@shoogle
Copy link
Contributor Author

shoogle commented Jul 10, 2016

It looks like repitch mode was actually broken a few weeks ago by 1a8cdf1. It might be a good idea to have a test for repitch mode. I'll make one when I get around to making tests for the other modes.

@mscscf
Copy link

mscscf commented Sep 21, 2017

I pulled MuseScore-master from GitHub.

I have MuseScore2 version 2.1.0 installed.

Do I need to install MuseScore-master to get the new dropdown?

@lasconic
Copy link
Contributor

No, the dropdown is already in MuseScore 2.1

@mscscf
Copy link

mscscf commented Sep 21, 2017

Do you know what I need to do to get the new Note Input options to show? The 3 new Note Input options do not show preferences.

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Sep 21, 2017 via email

@mscscf
Copy link

mscscf commented Sep 21, 2017

image

Where is the "N" icon?

@mscscf
Copy link

mscscf commented Sep 21, 2017

image

@Jojo-Schmitz
Copy link
Contributor

@mscscf
Copy link

mscscf commented Sep 21, 2017

Ok thanks for your help. I see them now. I'll give them a try.

Somehow I got the idea the options were in preferences. Not just on the main screen.

@mscscf
Copy link

mscscf commented Sep 21, 2017

How can I pick up the nightly builds instead of waiting for version 3.0? In case there are fixes in the nightly builds.

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Sep 21, 2017 via email

@mscscf
Copy link

mscscf commented Sep 21, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants