fix #117901: support #include, change #define behavior, support <global> #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| f = newFile; | ||
| if (!f->open(QIODevice::ReadOnly)) { | ||
| qDebug("ZInstrument: cannot load %s", qPrintable(path + "/" + newFilename)); | ||
| return false; |
There was a problem hiding this comment.
f is not deleted here right?
There was a problem hiding this comment.
here better not (there could be more on the stack)
There was a problem hiding this comment.
or better something that actually cleans the stack
hpfmn
force-pushed
the
ZerberusIncludeGlobal
branch
3 times, most recently
from
7659d96
to
8a64c55
Compare
| @@ -16,6 +16,7 @@ | |||
| #include <QFileInfo> | |||
| #include <QStringList> | |||
| #include <sndfile.h> | |||
| #include <stack> | |||
There was a problem hiding this comment.
the stack is not used right?
hpfmn
force-pushed
the
ZerberusIncludeGlobal
branch
from
8a64c55
to
ad9d46a
Compare
hpfmn
force-pushed
the
ZerberusIncludeGlobal
branch
from
ad9d46a
to
f5aabd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for more information see https://musescore.org/en/node/117901