fix #121746: ask for confirmation before deleting a workspace #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| QMessageBox::StandardButton reply; | ||
| reply = QMessageBox::question(0, | ||
| QWidget::tr("Warning"), | ||
| QWidget::tr("Are you sure?"), |
There was a problem hiding this comment.
We probably need a better message and title no? If you let your computer on this dialog for a while and come back: Are you sure about what?
There was a problem hiding this comment.
Proposal.
Title. Are you sure?
Do you really want to delete the workspace workspacename?
There was a problem hiding this comment.
Agreed, but same is true for the other PR I referenced.
There was a problem hiding this comment.
I'll change it for both
There was a problem hiding this comment.
Do you really want to delete the "name" palette/workspace? would be more grammatical.
There was a problem hiding this comment.
OK, let's do that then
Jojo-Schmitz
force-pushed
the
workspace-delete-confirm
branch
from
bee8d8a
to
ccf5299
Compare
and change Qt's `foreach(a, b)` to C++11's `for (a : b)` Also improve the delete palette message
Jojo-Schmitz
force-pushed
the
workspace-delete-confirm
branch
from
ccf5299
to
d0e8152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and change Qt's
foreach(a, b)to C++11'sfor (a : b)Also improve the delete palette message
Should go to master and 2.0.4, just like PR #2525