partial fix #121706: custom dashed options not working #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
cresc-line-dash-options
branch
2 times, most recently
from
639b93f
to
d138c39
Compare
|
Shouldn't those values of dash length and dash gap be expressed in spatium units? |
Jojo-Schmitz
force-pushed
the
cresc-line-dash-options
branch
4 times, most recently
from
631a3ae
to
666b595
Compare
|
Definitely need to be in spatium indeed. |
and having bad defaults and backward compatibility issues, esp. for dim./cres. lines. Also fix capitalisation of "Set style" button and accessibility info and buddies for inspector_line.ui.
Jojo-Schmitz
force-pushed
the
cresc-line-dash-options
branch
from
666b595
to
bc4c6e5
Compare
Jojo-Schmitz
force-pushed
the
cresc-line-dash-options
branch
from
733b602
to
4886450
Compare
|
With this the dashes and gaps are way too wide and I don't get why, any hint would be appreciated |
|
So I was wrong, it doesn't need to be a spatium. Qt expects a factor of the "line width" for the dash gap and dash length. So it should already scale correctly with the spatium. Thank you for looking into it, Werner will use your code to make a proper fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and having bad defaults and backward compatibility issues,
esp. for dim./cresc. lines.
Also fix capitalisation of "Set style" button and
accessibility info and buddies for inspector_line.ui