Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of special casing the z-order of ledger lines and images #2802

Merged
merged 1 commit into from Sep 6, 2016
Merged

get rid of special casing the z-order of ledger lines and images #2802

merged 1 commit into from Sep 6, 2016

Conversation

Jojo-Schmitz
Copy link
Contributor

No description provided.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Aug 30, 2016 •
edited

mtest fix to follow. And yes, it'll most probably collide with #2789 (edit: and now with #2810), I'll deal with this if and when it happens

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Aug 30, 2016 •
edited

Outch, this are far more mtest failures than I expected, and very ones different too. I was expecting it to fail in tst_scripting only

@Jojo-Schmitz
Copy link
Contributor Author

Now with fixes for the tst_scripting mtest I was expecting to be needed

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Sep 3, 2016 •
edited

I wonder whether changing just one of the two elements works without causing all these failures. And I have the feeling that one element, if any, got to be IMAGE.

@lasconic
Copy link
Contributor

lasconic commented Sep 6, 2016

All the failures are due to ElementName not being in sync with the element type enum I believe.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Sep 6, 2016 •
edited

Outch, what a stupid mistake of mine. Let's see whether this is better then...

And the next stupid mistake, it really helps to save modified files before the git commit :-/

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Sep 6, 2016 •
edited

See also https://musescore.org/en/node/28041 and https://musescore.org/en/node/120466, which lead to the introduction of these special casing

@lasconic lasconic merged commit 09859c9 into musescore:master Sep 6, 2016
@Jojo-Schmitz Jojo-Schmitz deleted the stacking-order branch September 6, 2016 16:19
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jojo-Schmitz @lasconic