Fixes for infos shown in Score Properties #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
changed the title
This was referenced Dec 29, 2016
Jojo-Schmitz
force-pushed
the
score-props
branch
from
9684b02
to
6c6010b
Compare
|
Rebased, apparently the commit dealing with API level not only caused conflicts, but also is no longer needed in master. |
for scores from 2.0 or later, actually for scores created after the move from sourceforge to GitHub
Jojo-Schmitz
force-pushed
the
score-props
branch
from
6c6010b
to
2bbf303
Compare
there's no real need for this and it changes the score properties in the metaedit dialog after autosave. It also prevents leftover temp files, apparently in this particular case of scores 'imported' from 1.x or 2.x the temp files are not deleted on a clean exit. Temp files for real imports and scores of the current version are getting cleaned up though.
Jojo-Schmitz
force-pushed
the
score-props
branch
from
7081604
to
f6b70bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for scores from 2.0 or later, actually for scores created after the move from sourceforge to GitHub
A very similar fix should go to the 2.1 branch. This one here won't apply cleanly there though, so I made #2936