fix #152766: Add keyboard shortcuts for up bow and down bow symbols #2924
Conversation
| @@ -604,6 +604,26 @@ Shortcut Shortcut::_sc[] = { | |||
| { | |||
| MsWidget::SCORE_TAB, | |||
| STATE_NORMAL | STATE_NOTE_ENTRY, | |||
| "add-stringsUpBow", | |||
| QT_TRANSLATE_NOOP("action","Up bow"), | |||
| QT_TRANSLATE_NOOP("action","Toggle Up bow"), | |||
| STATE_NORMAL | STATE_NOTE_ENTRY, | ||
| "add-stringsDownBow", | ||
| QT_TRANSLATE_NOOP("action","Down bow"), | ||
| QT_TRANSLATE_NOOP("action","Toggle Down bow"), |
change shortcut.cpp fix #152766: Add keyboard shortcuts for up bow and down bow symbols
|
Is it fine now, or do I have to make more changes? |
| MsWidget::SCORE_TAB, | ||
| STATE_NORMAL | STATE_NOTE_ENTRY, | ||
| "add-stringsDownBow", | ||
| QT_TRANSLATE_NOOP("action","Down bow"), |
There was a problem hiding this comment.
Bow, uppercase here, (sorry, missed it first time round)
There was a problem hiding this comment.
So it should be "action", "Down Bow" ?
| @@ -604,6 +604,26 @@ Shortcut Shortcut::_sc[] = { | |||
| { | |||
| MsWidget::SCORE_TAB, | |||
| STATE_NORMAL | STATE_NOTE_ENTRY, | |||
| "add-stringsUpBow", | |||
| QT_TRANSLATE_NOOP("action","Up bow"), | |||
There was a problem hiding this comment.
Bow, uppercase here, (sorry, missed it first time round)
|
And then you should most probably squash into a single commit |
|
I'm having difficulty squashing into a single commit. I'm sorry, I'm new to using GitHub. |
|
What type of difficulty do you have? On the command line, in the MuseScore directory: a text editor should open. For all the lines but the first one, replace the word "pick" by "squash" and save the file. Then a new text editor will open, remove all the lines but the one of the right commit message. Read http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html again. |
|
I did this, but in the text editor I see more than 5 commits. The first commit is a8f4268. |
# The first commit's message is: fix #152766: Add keyboard shortcuts for up bow and down bow symbols change shortcut.cpp fix #152766: Add keyboard shortcuts for up bow and down bow symbols # This is the 2nd commit message: change shortcut.cpp
…thub.com/divya-urs/MuseScore-1 into 152766-keyboard_shortcuts_bowing_symbols
|
This doesn't look right at all |
|
I must have made some mistake. I'll close this pull request and open another one. |
No description provided.