fix #152766: Add keyboard shortcuts for up bow and down bow symbols #2928
Conversation
| @@ -982,6 +982,14 @@ | |||
| <key>toggle-insert-mode</key> | |||
| <seq>Ctrl+I</seq> | |||
| </SC> | |||
| <SC> | |||
There was a problem hiding this comment.
Given the different keyboard layouts—as discussed at https://musescore.org/en/node/152766—I know it's not as "sexy" to add a feature that the user has to enable, but it seems smartest to leave it to the users to define their own shortcuts. Thank you for your idea and coding!
There was a problem hiding this comment.
Thank you! So should I just remove the Shift+U and Shift+Z ?
There was a problem hiding this comment.
All eight lines in shortcuts.xml. They will be automatically created when the user assigns a shortcut.
There was a problem hiding this comment.
After adding a new commit to this branch that restores the previous shortcuts.xml:
git rebase -i HEAD~2
In the vi editor, change the second line to start with f instead of pick, write and quit.
Then git push -f to update this pull request.
There was a problem hiding this comment.
Thanks! I'll do that.
divya-urs
force-pushed
the
add_keyboard_shortcuts_bowing_symbols
branch
from
68b4d16
to
1b40bdc
Compare
| @@ -3162,6 +3162,8 @@ void Score::cmd(const QAction* a) | |||
| { "add-marcato", [this]{ addArticulation(SymId::articMarcatoAbove); }}, | |||
| { "add-sforzato", [this]{ addArticulation(SymId::articAccentAbove); }}, | |||
| { "add-trill", [this]{ addArticulation(SymId::ornamentTrill); }}, | |||
| { "add-stringsUpBow", [this]{ addArticulation(SymId::stringsUpBow); }}, | |||
There was a problem hiding this comment.
We should use camelCase here since others don't use it. Except this, it's good, I'll merge it and change it
No description provided.