Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #11261: improved logic for inserting measures #297

Merged
merged 2 commits into from Apr 17, 2013
Merged

fix #11261: improved logic for inserting measures #297

merged 2 commits into from Apr 17, 2013

Conversation

danielgarthur
Copy link
Contributor

-Insert now works when an element inside a measure is selected, instead of only when the whole measure is selected
-Inserting a measure selects the new measure, so that it is ready for input
-Inserting multiple measures checks that a measure (or element in a measure) is selected before displaying the dialog

@lasconic
Copy link
Contributor

Hi Daniel, thank for the pull request!
Could you sign the MuseScore CLA so that we can merge your code? http://musescore.org/en/cla
If you did already, discard my request and just give me your musescore.org username.

@danielgarthur
Copy link
Contributor Author

Hi Nicolas, I signed the CLA today.

}

//---------------------------------------------------------
// parentChordRest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be findMeasure

wschweer added a commit that referenced this pull request Apr 17, 2013
fix #11261: improved logic for inserting measures
@wschweer wschweer merged commit 1afd684 into musescore:master Apr 17, 2013
heuchi pushed a commit to heuchi/MuseScore that referenced this pull request Nov 13, 2013
worldwideweary pushed a commit to worldwideweary/MuseScore that referenced this pull request Feb 16, 2024
musescore#297)

(partial) backport of musescore#21280

Co-authored-by: Calum Matheson <mathesoncalum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants