Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mac deployment for all libraries #2973

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Conversation

AntonioBL
Copy link
Contributor

No description provided.

@AntonioBL
Copy link
Contributor Author

AntonioBL commented Jan 25, 2017

I could test a Nightly build and there was a leftover /usr/local/Cellar address inside one of the dependencies (libvorbisenc.2.dylib) of the dependency libsndfile.1.dylib of mscore.
This should hopefully solve it (as before, I could not test this change in a local compilation).

@Jojo-Schmitz
Copy link
Contributor

If you rebase to merge in @wschweer's last fix, c1a143f , this one should build

@AntonioBL
Copy link
Contributor Author

AntonioBL commented Jan 26, 2017

I finally managed to recreate a build environment under Mac and it seems this PR is not solving the issue.
I will try to update it.

@AntonioBL
Copy link
Contributor Author

Ok. Now it works (and I locally tested it), there was just a silly typo in the previous version of this PR.
I also rebased onto the latest master.

@lasconic lasconic merged commit d759ab0 into musescore:master Jan 26, 2017
@AntonioBL AntonioBL deleted the macprova branch February 5, 2017 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants