fix #166231: Ambitus gets reported an octave to high #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in Inspector, status bar and screen reader. Also getting rid of superfluos backslashes and an unneded code duplication
|
Should go to 2.1 and master, regardless that in master Ambitus currently doesn't work at all |
Jojo-Schmitz
commented
Jan 30, 2017
| int topOctave() const { return _topPitch / 12;} | ||
| int bottomOctave() const { return _bottomPitch / 12;} | ||
| int topOctave() const { return (_topPitch / 12) - 1; } | ||
| int bottomOctave() const { return (_bottomPitch / 12) - 1; } |
There was a problem hiding this comment.
using the same logic here as in libmscore/note.cpp, line 768
There was a problem hiding this comment.
Maybe this is a chance to add a “pitch to octave” macro (or static inline function) in a common header, and use that both in ambitus.h and note.cpp?
Otherwise, looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Inspector, status bar and screen reader.
Also getting rid of superfluos backslashes and an unneeded code duplication