2.1 fix to prevent Q or Shift+Q from resulting in 256th rests #3101
Conversation
ericfont
force-pushed
the
Prevent-256th-rests-from-Q-or-ShiftQ
branch
from
61b58c8
to
69f3cd6
Compare
libmscore/durationtype.cpp
Outdated
| ((newValue == int(DurationType::V_128TH)) && (newDots >= 1)) || | ||
| ((newValue == int(DurationType::V_64TH)) && (newDots >= 2)) || | ||
| ((newValue == int(DurationType::V_32ND)) && (newDots >= 3)) || | ||
| ((newValue == int(DurationType::V_16TH)) && (newDots >= 4))) |
There was a problem hiding this comment.
note: I'm just being extra safe with the quad-dotted 16th note, although I haven't actually been able to produce a quad-dotted note yet...
There was a problem hiding this comment.
There is no provision for 4 dots in MuseScore 2. In Chord, the NoteDot array has only 3 slots.
There was a problem hiding this comment.
ok... Well so I guess I don't need that final condition.
There was a problem hiding this comment.
I'll repush, this time forgetting about that final condition, but also changing those == into >= just because.
There was a problem hiding this comment.
@lasconic If the eventual limits in master is 1024th, then I guess I should make a corresponding master fix which prevents the corresponding cases that would produce 2048th rests...sound good?
Must prevent Q or Shift+Q from resulting in a note with a number of dots that would result in a 256th rest to balance it out. This causes problems because 256ths durations don't work on 2.1.
ericfont
force-pushed
the
Prevent-256th-rests-from-Q-or-ShiftQ
branch
from
69f3cd6
to
aeee109
Compare
Prevents problem described from comments 40-44 in https://musescore.org/en/node/175461#comment-682261, whereby pressing Q or Shift+Q might produce a dotted or double-dotted note duration that would have resulted in the subsequent creation of a 256th rest (which 2.1 code does not support, and which thus created other problems).