Basic Tests for Q, W, Shift+Q, Shift+W #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for basic functionally. Going between 128th duration & whole duration and applies commands 'half-duration', 'double-duration', 'dec-duration-dotted', 'inc-duration-dotted' Class Score gets methods cmdDoubleDuration(), cmdHalfDuration(), cmdIncDurationDotted(), cmdDecDurationDotted() which are public wrappers around private method cmdIncDecDurationDotted. Simplified the text description of the commands
ericfont
commented
Mar 24, 2017
| { "double-duration", [this]{ cmdDoubleDuration(); }}, | ||
| { "half-duration", [this]{ cmdHalfDuration(); }}, | ||
| { "inc-duration-dotted", [this]{ cmdIncDurationDotted(); }}, | ||
| { "dec-duration-dotted", [this]{ cmdDecDurationDotted(); }}, |
There was a problem hiding this comment.
I think these wrapper functions make code easier to read.
ericfont
commented
Mar 24, 2017
| void cmdDoubleDuration() { cmdIncDecDuration(-1, 0); } | ||
| void cmdHalfDuration() { cmdIncDecDuration( 1, 0); } | ||
| void cmdIncDurationDotted() { cmdIncDecDuration(-1, 1); } | ||
| void cmdDecDurationDotted() { cmdIncDecDuration( 1, 1); } |
There was a problem hiding this comment.
public wrapper functions around the private function cmdIncDecDuration
ericfont
commented
Mar 24, 2017
| QT_TRANSLATE_NOOP("action","Decrease Duration to Next Smaller Dotted or Non-Dotted Duration"), | ||
| QT_TRANSLATE_NOOP("action","Decrease duration to next smaller dotted or non-dotted duration"), | ||
| QT_TRANSLATE_NOOP("action","Decrease Duration Dotted"), | ||
| QT_TRANSLATE_NOOP("action","Decrease duration dotted"), |
There was a problem hiding this comment.
The command's description has been simplified, for reasons I mentioned in: https://musescore.org/en/node/175461#comment-682611
|
note this should go in both master and 2.1, I think. |
|
2.1 is too different to merge this automatically. Would you mind creating a new PR ? |
|
ok, I'll create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for basic functionally. Going between 128th duration & whole duration and applies commands 'half-duration', 'double-duration', 'dec-duration-dotted', 'inc-duration-dotted'
Class Score gets methods cmdDoubleDuration(), cmdHalfDuration(), cmdIncDurationDotted(), cmdDecDurationDotted() which are public wrappers around private method cmdIncDecDurationDotted.
Simplified the text description of the commands