fix #187556: Allow wider dashed slurs/ties #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
wide-dashed-slurties
branch
from
39eff84
to
f0d8aab
Compare
|
For master we may want to expose settings for dash and gap length, similar to (de-)crescendo lines and hairpins. Or even have SlurTie inherit from SLine, and that way get the same extended set of options. |
|
That will go to master only then. Note that in my experience CustomDashLine are very slow to draw. |
|
As it is currently it could well go to both. For master it could get extended further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could even make it into 2.1. All (previous) 2.x version would show the slurs/ties as solid (and a blank field for type in Inspector), but saving again (not altering those slurs/ties) would leave them unaltered, and show as wide dashed in versions that do support it