fix #189741: corruption on change duration with local timesig #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue https://musescore.org/en/node/189741, I propose disabling the change actual duration command for a measure affected by a local time signature. But due to the way things are structured, detecting this at the right time seemed tricky, whereas actually fixing the main problem (initial state of measure not converted correctly) is pretty straightforward. This PR suggests two ways of getting the job done.
Still, because this affects how the change actual duration command works, I don't know that it is worth merging for 2.1 right now. Maybe better to wait until we have some more fixes for other local time signature issues and can do more rigorous testing.