Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW5.3 ld.exe .rsrc merge failure: duplicate leaf #3153

Merged

Conversation

jeetee
Copy link
Contributor

@jeetee jeetee commented Apr 23, 2017

resfile.o is already included via object1.rsp, there should be no need to explicitly link it again

See discovery thread https://musescore.org/en/node/181796

@lasconic
Copy link
Contributor

Brilliant !

@lasconic lasconic merged commit fb326d5 into musescore:master Apr 24, 2017
@jeetee jeetee deleted the mingw53_ld_rsrc_merge_failure_duplicate_leaf branch April 24, 2017 11:13
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 5, 2018

I wondered whether this would be beneficial to the 2.2 branch too, so I checked and 2.2 does build with this commit being cherry-picked (there's a conflict due to some formatting/indenting changes though, but that is easy to resolve)
But see yourself in #3437, we'll see whether Travis and AppVeyor are happy with it ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants