Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #195891 reduce save online window height #3167

Conversation

jeetee
Copy link
Contributor

@jeetee jeetee commented May 9, 2017

only verified in the designer view of QtCreator, but should be fine given the minimal change

@Jojo-Schmitz
Copy link
Contributor

You can test it using the -e option

@jeetee
Copy link
Contributor Author

jeetee commented May 10, 2017

[WIP] while the initial size of the window is fine, it snaps to a bigger minimal size once you attempt to resize it.

From the console:
Warning: setGeometry: Unable to set geometry 615x550+493+155 on QWidgetWindow/'U
ploadScoreDialogWindow'. Resulting geometry: 615x729+493+155 (frame: 8, 30, 8,
8, custom margin: 0, 0, 0, 0, minimum size: 420x473, maximum size: 16777215x1677
7215). (:0, )

Especially interesting is the minimum size it gives itself for the frame, whilst not allowing you to go that small.. I'm wondering if it has to do with the contents being a FormLayout here rather than a GridLayout..
I'll dive a bit deeper into what other sizehints are set inside of the Form to see what is causing this high a minimal height.

@lasconic
Copy link
Contributor

lasconic commented Jun 5, 2017

Looking into it, did you find anything else?

@jeetee
Copy link
Contributor Author

jeetee commented Jun 24, 2017

Not too much; slightly annoyed and baffled by it.
Most occurrences of that error I can find are mostly related to either not setting the geometry on a window object, but a widget; or setting a geometry that is smaller than the window managers minimal size (for example to ensure visibility of title bar/buttons). Neither should be the case here.

This QTBUG seems slightly related (at least the same error response, but triggered by changing OS scaling of text) from January: https://bugreports.qt.io/browse/QTBUG-58027

And then there is this forumpost from May which seems to be the exact same issue, but has zero responses so far: http://www.qtcentre.org/threads/68266-window-size-out-of-control-error-is-setGeometryDp-Unable-to-set-geometry

@lasconic
Copy link
Contributor

lasconic commented Aug 1, 2017

Here is my take on it #3260
Trying it on mac

@lasconic lasconic closed this Aug 1, 2017
@jeetee jeetee deleted the 195891_reduce_save_online_window_height branch August 7, 2017 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants