Fix #209331: Updated Descriptions of Enharmonic shortcuts to reflect current implementation #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dinukadesilva
commented
May 30, 2017
•
dinukadesilva
commented
dinukadesilva
force-pushed
the
gh-209331
branch
4 times, most recently
from
b979fcf
to
51c1e2e
Compare
…current implementation.
|
1st commit could go to the 2.2 branch too, the 2nd commit should not |
Replaced the references of `enh-up` and `enh-down` to `enh-both` and `enh-current`
|
@Jojo-Schmitz Do you want me to make a pull request to 2.2 branch |
|
I don't think that is needed, @lasconic could cherry-pick that 1st commit, if he thinks it should go in |
|
1st commit is also in 2.2 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.