fix #211461: show text of other dynamics in status line #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasconic
reviewed
Jun 13, 2017
| return QString("%1: %2").arg(Element::accessibleInfo()).arg(this->dynamicTypeName()); | ||
| QString s; | ||
|
|
||
| if (dynamicType() == Dynamic::Type::OTHER) { |
There was a problem hiding this comment.
Would it be smart to override screenReaderInfo then? because the elision will not be nice when said by a screen reader.
There was a problem hiding this comment.
elipsis, not elison, right? If so: the same thing is used in Text::accessibleInfo() too
There was a problem hiding this comment.
Yes, I just stole this code from Text. But perhaps both should override screenReaderInfo(). I guess since a blind user can't see the text element itself in the score, hearing the full text read aloud would be especially important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we changed the behavior of other dynamics (aside from the standard ones) to export their text to MusicXML. This PR makes the status line & screenreader do the same.
Note the issue references originally was about a request for a change in playback semantics upon editing the dynamic text. But 1) the main requested change was apparently already made for 2.1 (not clearing the velocity setting on edit), and 2) the further request to possible update the velocity according to the modified text does not actually make sense to me.