Fix #232931 follow-up: change behavior of adding breaks from palette #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tested but it looks good! |
IsaacWeiss
force-pushed
the
breaks-palette-2
branch
from
91734e1
to
7175e7f
Compare
|
@MarcSabatella I also moved the line like you said. ;-) BTW, the Heisenbug http://imgur.com/a/vWbJG was occurring with the shortcut, too, but very rare either way, and not often enough for me to figure out the rule. |
|
Also see #3243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this does no harm; I initially thought it was buggy, but it turned out to be a pre-existing Heisenbug.