Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving scores opened by relative pathname from cmdline #3310

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

mirabilos
Copy link
Contributor

https://musescore.org/en/node/150956

The patch was tested against the 2.1 release and committed relative to the 2.2 branch.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Oct 11, 2017

As far as I can see it should apply cleanly to master too.
If you make the commit message starting with fix #150956:, that issue will get marked as fixed automagically once ths PR gets merged

@mirabilos
Copy link
Contributor Author

Thanks, I’ve updated the commit message.

As scorefile.cpp didn’t change between 2.1 and 2.2 it should work; master does contain some changes, but (in the function affected) only in the way things were translated, so it will likely just work there as well, yes.

@Jojo-Schmitz
Copy link
Contributor

Yes, I manually checked that this PR should not cause merge conflits with master, so should cherrypick cleanly

@mirabilos
Copy link
Contributor Author

@lasconic can we pretty please have this in 2.2? I’ve been carrying it in the Debian package since like forever…

@lasconic lasconic merged commit a12ba21 into musescore:2.2 Mar 15, 2018
@lasconic
Copy link
Contributor

Merged, also on master 28a54f3

@mirabilos
Copy link
Contributor Author

mirabilos commented Mar 15, 2018 via email

@mirabilos mirabilos deleted the fix-150956 branch March 16, 2018 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants