-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #184246: Add same string option in select notes #3312
Conversation
as mentioned on IRC: revision.h shoulnd not be there, check build/git/hooks/post-checkout and the README next to it on how to prevent this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That ain't any better, this file should not be in any commit. But I guess if you squash them it'll be OK
Did you mean squash? If yes, should I do it or it will be done by maintainers while merging the PR? |
Yes I meant squash (and corrected that typo, I blame it on my mobile's autocorrect) and no this needs to be done by you prior have the PR merged |
Sorry this is my first PR. I'm having some problems with git. To clarify I have to -
|
Yes. You can also to a |
6de11a7
to
b4da301
Compare
Looks good now and should also go into 2.2 IMHO |
Looks good. Will merge. I might add a check to see if there is some stringdata associated with the instrument, if not this option doesn't really make sense. |
Select -> More: ability to distinguish same pitch on a specific string in Tabs