fix #269024: Enable alignment of verse numbers in version 3.0 #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wschweer This is in your department :) Can you have a look ? |
|
@mattmcclinch Could you create an issue in the issue tracker and reference it in your commit message? It sounds like a burden right now but in the long run it does pay. |
mattmcclinch
changed the title
mattmcclinch
force-pushed
the
align-verses
branch
from
8ab5a1b
to
111d065
Compare
|
See issue #269024 |
|
I applied the patch manually, omitting the "toText()" casts. |
|
Okay, you know best. As you can probably guess, the only reason for the toText() casts was to force Text::layout1() to be used instead of calling Lyrics::layout1() recursively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 2.x, verse numbers line up automatically, but this is disabled in version 3.0. These changes enable verse number alignment in 3.0.