fix #269271: crash on drag'n'drop brackets to a score #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added correct check for Bracket properties. Previous implementation processed only BracketItem properties, but general Element properties were ignored.
|
The PR cannot be merged as it. Could you rebase on top of master, fix the conflicts and force push? |
|
Well, it is not possible to use Element::getProperty() directly from BracketItem, because the last is not a child of Element, but ScoreElement. The first part I'll do, of course. Thank you! |
|
Well, the crash is seemed to be fixed in 5783276. Similar solution was used without mentioning it. So, this PR is not actual anymore. |
anatoly-os
referenced
this pull request
Feb 12, 2018
|
Thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added correct check for Bracket properties.
Previous implementation processed only BracketItem properties, but general Element properties were ignored.