Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 6-str. Electric Bass and 5-str. Electric Bass (High C) plus Tablature #3460

Merged
merged 2 commits into from Feb 14, 2018

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Feb 11, 2018

plus Tablature. And also Baritone Guitar. See https://musescore.org/en/node/269344

@Jojo-Schmitz Jojo-Schmitz changed the title Add 6-str. electric bass Add 6-str. Electric Bass and 5-str. Electric Bass (High C) plus Tablature Feb 12, 2018
@lasconic
Copy link
Contributor

@Jojo-Schmitz
Copy link
Contributor Author

@mgavioli
Copy link
Contributor

I don't understand the need to add a new tab style: there are already (or at least there were in ver. 2) three 6-string tab styles. Am I missing something?

@lasconic
Copy link
Contributor

It's not about tab style. The ones we have are fine. it's about ready made instruments... Users are lazy and expect to see the instruments they want/own in the list. So it would be good to have ready made 5 and 6 strings bass with the most common tuning.

@mgavioli
Copy link
Contributor

Ok, I see, thanks for the additional details.

@lasconic
Copy link
Contributor

No pb. Thank you for being around carefully checking PRs !

@Jojo-Schmitz Jojo-Schmitz force-pushed the 6-str.-Bass branch 2 times, most recently from 4aaeaf8 to bc484d9 Compare February 13, 2018 13:30
@@ -9967,6 +9989,85 @@
<!-- <clef>TAB</clef> -->
<genre>common</genre>
</Instrument>
<Instrument id="5-string-electric-bass-high-c">
<longName>5-str. Electric Bass (High C/Tenor)</longName>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using this string for the trackname and make longname shorter ? "5-str. Electric Bass (High C/Tenor)" looks quite long on a score...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope I got it right now

as this came up as issues on Transifex
@lasconic lasconic merged commit 4b4be43 into musescore:master Feb 14, 2018
@Jojo-Schmitz Jojo-Schmitz deleted the 6-str.-Bass branch February 14, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants