Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right Click Menu #3609

Closed

Conversation

19joho66
Copy link
Contributor

@19joho66 19joho66 commented Apr 5, 2018

  • Implemented the right click context menu for note entry mode
  • Added right click menu in note edit mode to be able to do modifications on the spot.

There is a discussion going on here https://musescore.org/en/node/269001 and here #3535 about the possible ways to implement the right click menu.

This commit is the implementation of the version described here: https://musescore.org/en/node/99536. Since a lot has changed on the master branch since the original pull request #2401 from 2016, I did a reimplementation based on the actual master branch.

Additionally in this version the described menu also opens up if you right click on a notehead in "note edit mode" Right clicking on a selected note in the "note edit mode" opens up the normal menu which lets you cut, copy, paste, delete etc.

(If you would like to try this version of right click menu without building the master branch, I have build an evaluation version based on MusesScore 2.2. You can download it here: https://bitbucket.org/19JoHo66/musescoretestversions/downloads/ and place it in your MuseScore2.2 installation folder. Please keep in mind, that this version is only intended for the evaluation and testing of the right click menu)

@MarcSabatella
Copy link
Contributor

As someone who rarely uses the mouse for anything having to do with note input, I'm going to try to keep out of this and let those with more a vested interest set the direction. That said, I still favor the idea of having an easier way of enterings rests - an actual "enter rest using current duration now" command that doesn't require one to first toggle rest mode. Seems you could accomplish this by simply adding "rest" to the context menu (perhaps replacing "pad-rest")?

+ Added right click menu in note edit mode to be able to do modifications on the spot.
@19joho66
Copy link
Contributor Author

I guess this is redundant now

@MarcSabatella
Copy link
Contributor

Not necessarily, I still think it's a good idea, but it would need to be updated.

@19joho66 19joho66 deleted the RightClickNoteEdit-Reloaded branch March 1, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants