Started Editing instruments.xml to better align with standards #3611
Conversation
Removed "instruments" from Genre type. Changed "ethnic" with "world".
Added new <Genre id> for "Pop/Rock", "Concert Band", "Marching", "Electronic", and "Classroom" Genres to better align with needs of popular music segment (GuitarPro) and education segment. Updated <genre> attributes for every instrment.
Updated <InstrumentGroup> naming syntax to emphasize instrument family and more clearly differentiate (ex: "Marching Percussion" to "Percussion - Marching", "Plucked Strings" to "Strings - Plucked")
|
Worth mentioning that this started from https://musescore.org/en/node/270611 We could change the name to I'm still of the opinion though that this is just too much of "political correctness", Hmm, well, there are I really like the change of I think you'd need to sign the CLA (even staff members should have to do that IMHO) |
|
About Ethnic vs World, political correctness put aside, "World music" seems to be a lot more popular way to name the same thing. It's what wikipedia uses for example https://en.wikipedia.org/wiki/World_music So I would go for it. And sure, change the id as well, it doesn't really matter, it could be foo or bar, but it's a lot easier to have an id relating to the visible string. To limit the damage on the history of the file, let's keep the commit separated for this PR. |
| @@ -10429,7 +10429,7 @@ | |||
| </Instrument> | |||
| </InstrumentGroup> | |||
| <InstrumentGroup id="strings"> | |||
| <name>Strings</name> | |||
There was a problem hiding this comment.
I like the less english but more structured way. It will make sorting more visual.
| @@ -1,19 +1,19 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Note for myself. Or @danieljray if you manage to do it : Change the commit message and keep only the second line.
There was a problem hiding this comment.
Also fix the indent for Genre
share/instruments/instruments.xml
Outdated
| @@ -5143,8 +5143,8 @@ | |||
| <genre>marching</genre> | |||
| </Instrument> | |||
| <Instrument id="snare-drum"> | |||
| <longName>Snare Drum</longName> | |||
| <shortName>Sn. Dr.</shortName> | |||
| <longName>Concert Snare Drum</longName> | |||
There was a problem hiding this comment.
conflicts with mtest for importmidi, see https://travis-ci.org/musescore/MuseScore/jobs/363144548#L5066-L5101
share/instruments/instruments.xml
Outdated
| @@ -5124,7 +5124,7 @@ | |||
| <name>Percussion - Unpitched</name> | |||
| <Instrument id="drumset"> | |||
| <longName>Drumset</longName> | |||
| <shortName>Drs.</shortName> | |||
| <shortName>D. Set</shortName> | |||
There was a problem hiding this comment.
Conflicts with mtest for importmidi, see https://travis-ci.org/musescore/MuseScore/jobs/363144548#L5031-L5065 and https://travis-ci.org/musescore/MuseScore/jobs/363144548#L5102-L5145
|
Merged manually in #3613 |
Objective is to more closely match naming conventions, categorization, and organization found in Sibelius and Finale to improve familiarity for users migrating to MuseScore.