WIP: fix #271198: Add a more flexible way to choose noteheads in drumset for percussion instrument #3620
Conversation
…or percussion instrument
mscore/editdrumset.cpp
Outdated
| @@ -111,9 +113,46 @@ EditDrumset::EditDrumset(const Drumset* ds, QWidget* parent) | |||
| pitchList->setColumnWidth(1, 60); | |||
| pitchList->setColumnWidth(2, 30); | |||
|
|
|||
| QComboBox* combos[] = { wholeCmb, halfCmb, quarterCmb, doubleWholeCmb }; | |||
| for (QComboBox* combo : combos) { | |||
| // TODO replace smuflRanges by a list of selected symbols | |||
There was a problem hiding this comment.
@danieljray Could you provide a full list of notehead glyphs from smufl that would make sense for drums. Not only for VDL but more globally? Right now, I used every single one in the noteheads range http://www.smufl.org/version/latest/range/noteheads/ which is too much (parenthesis etc...) but not enough since http://www.smufl.org/version/latest/range/roundAndSquareNoteheads/ and http://www.smufl.org/version/latest/range/slashNoteheads/ are not included... So we will need to hardcode a list...
There was a problem hiding this comment.
I recommend to add the following, currently missing from 3.0:
noteheadXOrnate
noteheadTriangleRightBlack
noteheadCircleSlash
noteheadRoundWhiteWithDot
noteheadLargeArrowUpBlack
| else if (tag == "noteheads") { | ||
| while (e.readNextStartElement()) { | ||
| const QStringRef& tag(e.name()); | ||
| _drum[pitch].noteheads[int(NoteHead::name2type(tag.toString()))] = Sym::name2id(e.readElementText()); |
There was a problem hiding this comment.
A bit dangerous for the changes in future formats, may lead to crash. I would add index boundary check before. I will add within a weekend.
There was a problem hiding this comment.
Sure. It's rough code for the moment.
| @@ -119,6 +119,7 @@ class NoteHead final : public Symbol { | |||
| HEAD_H, | |||
| HEAD_H_SHARP, | |||
|
|
|||
| HEAD_CUSTOM, | |||
There was a problem hiding this comment.
Watch out, the addition of this custom type can have weird implication since HEAD_GROUPS is used to "loop through" the enum. I believe I catch all problems but still, review welcome.
There was a problem hiding this comment.
Sure, I'm working on it. What is the best way to introduce changes? Should I make a PR based on your changes?
There was a problem hiding this comment.
Sure, you can do a PR based on my branch. Let's talk when you are done.
| for (auto symName : (*smuflRanges())[range]) { | ||
| SymId id = Sym::name2id(symName); | ||
| if (!excludeSym.contains(symName)) { | ||
| QIcon icon; |
There was a problem hiding this comment.
The painting here works well with some glyphs and less well with others.. no idea why for the moment. The glyph are supposed to be positioned the same.
|
See #3631 |
No description provided.