fix #228531: Courtesy clefs don't appear on lines ending in repeat barlines #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added comment to the issue. If the mentioned ambiguity is clear in music notation, let's merge the PR. https://musescore.org/en/node/228531#comment-838086 |
|
According to the discussion in the related issue, this fix leads to ambiguity and better and more complex implementation is supposed to be done for this task (in 3.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #228531: Courtesy clefs don't appear on lines ending in repeat barlines.
While I understand the reasoning behind hiding a courtesy clef if it comes at the end of a repeat, the example in the bug report shows why this is not the correct thing to do. After all, it is easy to hide a courtesy clef if it should not be shown. It is much harder to show a courtesy clef if MuseScore wants to hide it.