fix #273159: Crash when pasting note with receiving tie on a new score #3719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to this issue which happens when trying to paste (or even load from a file) tied notes if a note has sufficiently large track number specified. In the example shown in the issue description something like this is pasted to the score:
so the Note was considered to be at the 2nd staff which may eventually not exist in the destination score. Thus
staff()
calls for the note return a null pointer, and the absence of check for it leads to its dereferencing and a crash of the program. This patch adds the necessary nullpointer checks which prevents program crashes in such cases.