Fix #269952: allow new templates to be shown in new score wizard w/o restart #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
changed the title
|
FWIW, things have already changed in this respect for 2.3 as a result of the "extension" changes. It is not the case that things are updated every time you visit Edit / Preferences. This happens because preferencesChanged() calls updateNewWizard(). If this work for preferences, seems we could take advantage of this and do the same thing here to make this a one-line change? |
|
Feel free to propose this ;-) |
|
Oh, you mean removing all(most) the stuff from this PR and use |
|
See #3771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.3 counterpart for #3522, shamelessly stealing @finleylau 's code and adjusting it for 2.3 (and recycling an old branch of mine).
Travis failure due to being in Release mode now...
It works fine, I see no reason not to merge #3522 into master.
Merging this here into 2.3 might still be an option, although I understand that such a last minute change is frowned upon.