Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #166566: Exchange voices with partial measure selected works all the way to end of score #3790

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

mattmcclinch
Copy link
Contributor

See https://musescore.org/en/node/166566.

This function seems to assume that only entire measures are selected. This is understandable, since the operation works only on entire measures. If the selection ends at the end of a measure, t2 will be set to the start tick of the next measure (or the last tick in the score if there is no next measure), and m2 will be set to the measure that starts at t2 (or the last measure in the score if t2 is the last tick in the score). The only way t2 would be greater than m2->tick() would be if m2 were the last measure in the score. If this is the case, then m2->nextMeasure() is equal to 0, so the logic has not changed. What has changed is that if the selection ends somewhere in the middle of a measure, m2 is set to the correct measure at which to stop.

@lasconic
Copy link
Contributor

We missed that one for 2.3.2. A pity. Thanks @mattmcclinch anyway.

@lasconic lasconic merged commit e767cab into musescore:master Jul 31, 2018
@mattmcclinch mattmcclinch deleted the 166566-exchange-voice branch September 5, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants