Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #274028: Courtesy accidental on tied note ignored later in measure #3793

Merged

Conversation

mattmcclinch
Copy link
Contributor

@mattmcclinch
Copy link
Contributor Author

It occurs to me that checking the role of the accidental is probably unnecessary, and is potentially problematic, should MuseScore ever automatically add a courtesy accidental in this scenario (e.g. at the start of a new page). It should be enough to simply check if the accidental is not equal to nullptr.

@mattmcclinch
Copy link
Contributor Author

I have modified this PR in light of my previous comment. _accidental == 0 is indeed what I meant, despite what I said about checking if the accidental is not equal to nullptr.

@mattmcclinch mattmcclinch force-pushed the 274028-courtesy-accidental branch 4 times, most recently from ad23109 to 90d4d55 Compare July 8, 2018 20:59
@anatoly-os anatoly-os merged commit 2924466 into musescore:master Aug 14, 2018
@mattmcclinch mattmcclinch deleted the 274028-courtesy-accidental branch September 5, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants