Revert the unison restriking patch #3797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The restriking patch went into 2.2 (and thus 2.2.1, 2.3, 2.3.1) while it is not unquestioned. It was never meant to last; MIDI channel assignment to individual voices must be made user-friendly, but then, a reversal was intended by upstream. This diff implements said reversal, in preparation of those other (UI, mostly) changes. Bug: https://musescore.org/en/node/12971
|
I believe @lasconic changed this differently for musescore backend 2.3.1 |
|
Indeed. I applied the same logic to audio export than playback. The backend is fixed. This PR is not needed anymore on the 2.x serie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to help debugging the popped-up again “Same note in different voices and lengths plays only the length of the shortest note” issue in
2.3.1.This patch will also need to be applied anyway when restriking will be reverted, once we have a more user-friendly UI for stave/voice → channel assignment, so it’s not completely useless… it’s effectively reverting the second commit (96d95c7) from the
3.0PR, except against2.3.1.