Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #274204: Regression: Ambitus causes a crash just while clicking on it #3825

Merged
merged 1 commit into from Jul 25, 2018

Conversation

mattmcclinch
Copy link
Contributor

@Jojo-Schmitz
Copy link
Contributor

Travis is not happy, but not due to the change in this PR, all meets passed

@mattmcclinch
Copy link
Contributor Author

mattmcclinch commented Jul 23, 2018

Jojo-Schmitz wrote:
And/or extend the local array with HEAD_CUSTOM?

There is no corresponding option in the combo box for HEAD_CUSTOM, so it would have to be added to inspector_ambitus.ui as well. But do we even want to allow custom noteheads in Ambitus?

@Jojo-Schmitz
Copy link
Contributor

I'm not sure why we allow different noteheads at all, after all this is for early music. But if we allow them, then I don't see why excluding some.
Then again that would add new strings to translate, so I don't think we want it for 2.3.2.

@mattmcclinch
Copy link
Contributor Author

As I understand it, custom noteheads are only used for Drumset staves, and the ambitus is only meaningful for pitched instruments.

@Jojo-Schmitz
Copy link
Contributor

We might want to discuss this for master, for 2.3.2 this PR is good as it is IMHO

@lasconic lasconic merged commit b027a16 into musescore:2.3.2 Jul 25, 2018
@mattmcclinch mattmcclinch deleted the 274204-ambitus branch September 5, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants