Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #276149: Resizing bracket causes crash #3953

Merged
merged 2 commits into from Sep 14, 2018

Conversation

mattmcclinch
Copy link
Contributor

See https://musescore.org/en/node/276149.

The problem is that layoutLinear() is called before the brackets are removed from the selection list. Moving this chunk of code further down in the function solves the problem.

Notice that the brackets are not re-selected after layoutLinear() is called. I tried to do this using the data stored in selectedBrackets, but it did not seem to work. It works better in Page View, but even then it may be a little buggy.

@mattmcclinch
Copy link
Contributor Author

I also solved a problem described in https://musescore.org/en/node/273292.

@anatoly-os
Copy link
Contributor

Interesting thing is that layoutLinear() is only about continuous view. But mentioned issues say nothing about Continuous view.

@mattmcclinch
Copy link
Contributor Author

The score from issue 276149 opens in Continuous View by default. Bug reports do not always provide all the relevant information at first.

@anatoly-os anatoly-os merged commit d83a8ee into musescore:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants