fix #276194 Allow MIDI devices to be refreshed without having to restart MuseScore #3962
Conversation
blackears
changed the title
|
Sounds very useful. 😃 |
blackears
force-pushed
the
276194-restarting-MIDI-driver
branch
3 times, most recently
from
f173843
to
ef1b565
Compare
|
@blackears could you please add "fix #" at the beginning of the PR title. Also, please edit commit message and add "fix #276194: " at the beginning so the related issue will be closed automatically once this PR is merged. |
blackears
changed the title
blackears
force-pushed
the
276194-restarting-MIDI-driver
branch
from
ef1b565
to
8d7d511
Compare
mscore/prefsdialog.cpp
Outdated
| // rescanDrivers | ||
| //--------------------------------------------------------- | ||
|
|
||
| void PreferenceDialog::rescanDriversClicked() |
There was a problem hiding this comment.
Isn't it possible to reuse the code to avoid duplication?
|
shouldn't the enable/disable MIDI toggle in the toolbar also result in a rescan? |
|
It does not result in a rescan, but clicking Apply in the preferences can if you change your driver. |
blackears
force-pushed
the
276194-restarting-MIDI-driver
branch
2 times, most recently
from
c56b7c8
to
08ed13e
Compare
|
But maybe it should result in a rescan? |
blackears
force-pushed
the
276194-restarting-MIDI-driver
branch
from
915c0f9
to
1685b7d
Compare
|
I've updated it so that when you switch the MIDI toggle button to on, the audio engine will be rebuilt which should connect to any MIDI keyboard that has been added. |
blackears
force-pushed
the
276194-restarting-MIDI-driver
branch
from
1685b7d
to
d00b9d6
Compare
anatoly-os
changed the title
|
@blackears could you please remove the dash after issue number? I will check the PR again and merge after the release, so it will be in one of the first updates to 3.0. |
Fixed memory leak/lack of handle closing when deleting Port Audio engine. Can now have MIDI devices be discovered by pressing button in Prefs/IO or by toggling the MIDI enabled button.
blackears
force-pushed
the
276194-restarting-MIDI-driver
branch
from
d00b9d6
to
32a6b12
Compare
|
@blackears great! I checked the case with my bluetooth headphones. I had to restart MuseScore when I plugged them, and now I'm able to switch to them on fly. Btw, there are two things which need to be fixed:
|
Fixed a bug in PortAudio where it wasn't deleting PortMidi upon deletion, which left the old MIDI ports open and blocked any new Drivers from using them.
Also added a button to Preferences/I/O. Now if a user turns off/on their MIDI keyboard while Musescore is running, they can open the Preferences/I/O, press Rescan MIDI Input and they should be able to use their keyboard again.