fix #276423: custom alignment of textline lost #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatoly-os
reviewed
Sep 26, 2018
| @@ -1406,7 +1406,7 @@ const TextStyle textLineTextStyle {{ | |||
| { Sid::textLineFontBold, Pid::BEGIN_FONT_BOLD }, | |||
| { Sid::textLineFontItalic, Pid::BEGIN_FONT_ITALIC }, | |||
| { Sid::textLineFontUnderline, Pid::BEGIN_FONT_UNDERLINE }, | |||
| { Sid::defaultAlign, Pid::ALIGN }, | |||
| { Sid::textLineTextAlign, Pid::ALIGN }, | |||
| { Sid::defaultOffset, Pid::OFFSET }, | |||
There was a problem hiding this comment.
Why not to replace defaultOffset with textLineTextOffset as well? Could you please describe the purpose of these settings to keep it for history?
There was a problem hiding this comment.
Oops, didn't realise that there was a specific one for defaultOffset as well - I'll replace that That's because there isn't a Sid called textLineTextOffset. Basically, most elements have generic defaultAlign and defaultOffset Sids, but the TextLine element maps the ALIGN pid to the more specific textLineTextAlign Sid. It seems like someone just copied and pasted this section without realising that for a TextLine, the ALIGN Pid is mapped to textLineTextAlign, not defaultAlign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://musescore.org/en/node/276423