fix #276868: Adding barline in mid-measure fails #4011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://musescore.org/en/node/276868.
The problem, of course, is that
BarLine::layout()
never gets called for the new BarLine, even during a full re-layout of the score, since it is not an EndBarLine. Thus the width of the BarLine's bbox remains at its default value of 0. For BarLines that are EndBarLines,BarLine::layout()
is called fromMeasure::createEndBarLines()
duringScore::collectSystem()
. If the barline is dragged from the palette,BarLine::layout()
is called fromScoreView::dragEnterEvent()
when the BarLine is dragged into the ScoreView.