Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12557 untitled score doesn't save (review needed) #405

Closed
wants to merge 1 commit into from

Conversation

AntonioBL
Copy link
Contributor

This pull request tries to fix the fact that untitled scores are not saved (or, actually, saved in the folder where mscore starts, without mscz extension and without warnings for overwriting). It mimics the use of the GUI save button. For scores with parts, it first switches to the main score and then saves.

@AntonioBL
Copy link
Contributor Author

Please review the method I used for switching to the relevant tab. I am not sure if I used the right method.
In particular, I found that I have to use these consecutive instructions:
setCurrentView(0,i);
tab1->setExcerpt(0);
setCurrentView(0,i);
without the last line of these three, the subtabs of the window for a score with parts are not properly updated.
I am not sure what would happen if saveFile() is not able, for whatever reason, to save the file: the checkdirty function as in this pull request would not return true.

@lasconic lasconic closed this Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants