fix #266205: do not deselect elements in Score::selectAdd #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the issue with "select similar elements" feature not working in some circumstances (at least when applied to ties). The proposed solution is to remove deselection of elements from
Score::selectAddsince it is not an expected behavior of this function and all of those chunks of code that use this function do not rely on such a behavior. Deselecting selected elements on Ctrl+click is already handled in ScoreView so this functionality is not broken by this patch.The fact that
Score::scanElementscan scan some elements more than one time can also be considered an issue but I believe that it is much more important for it to touch all elements rather than aim for doing it one time only. So this issue can be postponed I guess.There is also a suspicious usage of
Score::selectin ChangeElement::flip but there is probably some typo there. The question is what kind of typo is there exactly.