fix #276461: Custom text styles in previous versions of MS changed to User-1, User-2 etc. #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like. To me the final thing needed (aside from bug fixes) to feel like the new style facility can do everything the old could (and then some). |
anatoly-os
reviewed
Nov 14, 2018
mattmcclinch
force-pushed
the
276461-user-text-styles
branch
from
97a17e2
to
fa24832
Compare
|
@mattmcclinch could you please rebase the PR? |
mattmcclinch
force-pushed
the
276461-user-text-styles
branch
from
fa24832
to
562add1
Compare
|
Needs a rebase to have a chance of being merged. Personally, I'd love to see it. |
mattmcclinch
force-pushed
the
276461-user-text-styles
branch
4 times, most recently
from
de7e548
to
e82283a
Compare
… User-1, User-2 etc.
mattmcclinch
force-pushed
the
276461-user-text-styles
branch
from
e82283a
to
bfbae7f
Compare
|
I performed the rebase, and as far as I am concerned, this is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://musescore.org/en/node/276461.
This allows user text styles to be renamed, and preserves user text style names imported from 2.x.