Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #286600: Use same dependencies for MinGW as are used for MSVC #4120

Merged
merged 1 commit into from
Apr 27, 2019

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Nov 8, 2018

works for compile, i.e. the header files are found and also for make install, i.e. the dlls are found and copied/renamed onto the instal folder (win32install or win64install), but not yet at link time, i.e. the libs are not found at that step, help needed there...

Edit: I think I got it now (basically thanks to the hint that MinGW doesn't need the static libs)

@anatoly-os
Copy link
Contributor

anatoly-os commented Nov 8, 2018

Mingw doesn't need static libs. It somehow generates it by itself. Need to check to give more details.

Btw, FYI, I'm implementing WinSparkle which won't work with mingw from the box. It means autoupdating won't be supported from the box.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Nov 8, 2018

Mingw doesn't need static libs. It somehow generates it by itself. Maybe that is why the linking takes so long?

Well, for self-built version WinSparkle won't be needed anyhow ;-)

@Jojo-Schmitz Jojo-Schmitz changed the title Using same dependencies for MinGW as are used for MSVC Use same dependencies for MinGW as are used for MSVC Nov 8, 2018
@Jojo-Schmitz Jojo-Schmitz force-pushed the MinGW-64bit branch 3 times, most recently from 166b928 to 4a8de45 Compare November 14, 2018 11:34
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Mar 14, 2019

Esp. helpful when switching between Qt versions (like from 5.9.x to 5.12.2, which does again provide a 32bit MinGW), as all dependencies are in one place rather than scattered about in Qt directories and need to get copied across to a different Qt/Tools directory time and time again.
And there are still some 'die-hards' prefering QtCreator/MinGW over MSVS/VC...
Doesn't affect anybody else as far as I can see.
In any case: it clearly is the cleaner solution.

@Jojo-Schmitz Jojo-Schmitz force-pushed the MinGW-64bit branch 2 times, most recently from 6dd8f95 to 8ac7456 Compare March 14, 2019 13:14
@Jojo-Schmitz
Copy link
Contributor Author

See also https://musescore.org/en/node/286600

@Jojo-Schmitz Jojo-Schmitz changed the title Use same dependencies for MinGW as are used for MSVC Fix #286600: Use same dependencies for MinGW as are used for MSVC Mar 24, 2019
@dmitrio95
Copy link
Contributor

Looking through the changes, it seems they indeed should not change anything that worked previously for all compilers except MinGW. Still I didn't pay much attention to MinGW changes, but if they work correctly I see no reasons not to merge them (especially given that MinGW seems to be considered unsupported officially).

Also after these changes the MinGW compile instructions in Handbook will need an update. @Jojo-Schmitz, will you do such an update?

@Jojo-Schmitz
Copy link
Contributor Author

Yes, I'll update those instructions

@dmitrio95
Copy link
Contributor

OK, then let's merge it, I hope it helps MinGW users.

@dmitrio95 dmitrio95 merged commit 82f27b7 into musescore:master Apr 27, 2019
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Apr 27, 2019

Thanks, https://musescore.org/en/handbook/developers-handbook/compilation/compile-instructions-windows-mingw-git is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants