fix #278053 - Failed assert on MusicXML import #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI's mtests are not happy with this, see https://travis-ci.org/musescore/MuseScore/jobs/453642107#L5574-L5616, I don't see though how the changes in this PR relates to octave changes in XML import/export? |
|
Status update: mtest fails because the third part in testVirtualInstruments.xml now gets a staff type percussion, which was pitched before. Note that it is kind of a corner case, as this happens only when a virtual instrument is used and no midi information is present. Still investigating. |
…stVirtualInstruments.xml)
|
Fix pushed, waiting for Travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.