fix #278339 Fix crash when note entered in piano roll #4158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing crash when note is entered in piano roll editor before any has been selected or a note duration has been chosen. Can now use piano roll editor to enter notes in 'gap' spaces with no chord or rest. Selection box color now reading properly from preferences. Shift now used for horizontal in mousewheel scrolling.
blackears
force-pushed
the
278339-crash-adding-note-before-inputState-initialized
branch
from
03093f7
to
613ae88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing crash when note is entered in piano roll editor before any has been selected or a note duration has been chosen.
Can now use piano roll editor to enter notes in 'gap' spaces with no chord or rest.
Selection box color now reading properly from preferences.
Rearranging mousewheel section to be in more logical order. Also swapping ctrl and ctrl-shift effects.