Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #278382: add Soprano, Mezzo-soprano, Alto, Tenor and Baritone with C Clef, for Early Music #4162

Merged
merged 1 commit into from Nov 25, 2018

Conversation

Jojo-Schmitz
Copy link
Contributor

No description provided.

@mirabilos
Copy link
Contributor

mirabilos commented Nov 17, 2018

Is this really worth the added visual clutter in the instruments dialogue?

I’d rather people just select the “instruments” and then drag the appropriate clefs from F9.

I mean, the change is literally only the clef.

@Jojo-Schmitz
Copy link
Contributor Author

It is only visible if you select all instruments (or just early music), not I'm the default of common.
IMHO it is worth it as it otherwise is impossible for users to create templates using those clefs.

@mirabilos
Copy link
Contributor

Saving as teplate removes the clef? Or template instantiation?

Is that deliberate, or shouldn’t perhaps that be the place to apply the wrench to?

@MarcSabatella
Copy link
Contributor

Clefs added to a score used as a template are treated no differently from notes or other elements added - they are not used when instantiating the template. That again is the issue here. Yes, in theory, it is possible to special-case an initial clef, so the template instantiation would look just enough at the content of a score to see if those exist. So far we haven't done that sort of thing. I'm not opposed to it, personally, but it is a more significant change.

@mirabilos
Copy link
Contributor

mirabilos commented Nov 18, 2018 via email

@anatoly-os anatoly-os merged commit 50b3059 into musescore:master Nov 25, 2018
@Jojo-Schmitz Jojo-Schmitz deleted the c-clef-voices branch November 26, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants