fix #276472: do not move slur if it doesn't intersect staff shape #4187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve issue 276472. This may be not the best solution for all cases but still should cover most common cases of bad layout of slurs due to their moving outside staff shape. The proposed patch checks whether the slur intersects staff shape (that includes only staff elements but not staff lines) and applies the position shift needed to move slur away from the staff shape only if intersection does really take place.
I say that this is not a perfect solution since the applied shift may be much larger than the one actually needed in some cases when staff shape consists of several separate parts. The complete solution could involve some rework of shapes that could allow handling such composed shapes more conveniently and efficiently. For example shape could me made consisted of something like a series of skylines. But this is still the question to consider, and for the nearest time the proposed solution may be good enough.