Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #276472: do not move slur if it doesn't intersect staff shape #4187

Merged
merged 1 commit into from Nov 24, 2018

Conversation

dmitrio95
Copy link
Contributor

This PR tries to resolve issue 276472. This may be not the best solution for all cases but still should cover most common cases of bad layout of slurs due to their moving outside staff shape. The proposed patch checks whether the slur intersects staff shape (that includes only staff elements but not staff lines) and applies the position shift needed to move slur away from the staff shape only if intersection does really take place.

I say that this is not a perfect solution since the applied shift may be much larger than the one actually needed in some cases when staff shape consists of several separate parts. The complete solution could involve some rework of shapes that could allow handling such composed shapes more conveniently and efficiently. For example shape could me made consisted of something like a series of skylines. But this is still the question to consider, and for the nearest time the proposed solution may be good enough.

@anatoly-os anatoly-os merged commit 9bbe00b into musescore:master Nov 24, 2018
@dmitrio95 dmitrio95 deleted the 276472-slurs-positioning branch April 30, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants