fix #121431: fit hairpins between adjacent dynamics #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts horizontal dimensions of hairpins to fit between adjacent dynamics, if any exist. No vertical aligning included, as it is already available in the form of begin/end text for hairpins. Still for some common cases the logic added by this commit is good enough. Dimensions calculation code is taken (with some adjustments) from 8bdd1af Also includes: - Rename/update Segment::findAnnotation[orElement] - Add Score::isPalette() to make it easier to distinguish between palette and normal scores on layout stage.
This was referenced Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts horizontal dimensions of hairpins to fit between adjacent
dynamics, if any exist. No vertical aligning included, as it is
already available in the form of begin/end text for hairpins.
Still for some common cases the logic added by this commit is
good enough.
Dimensions calculation code is taken (with some adjustments) from
8bdd1af
Also includes:
palette and normal scores on layout stage.